Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Unpin @discordjs/collection #10665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor!: Unpin @discordjs/collection #10665

wants to merge 1 commit into from

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Dec 24, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Unpins the package.

BREAKING CHANGE: discord.js now uses @discordjs/collection v3—a major version increase.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Dec 24, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Dec 24, 2024 7:49pm
discord-js-guide ⬜️ Ignored (Inspect) Dec 24, 2024 7:49pm

@Jiralite Jiralite marked this pull request as ready for review December 24, 2024 19:57
@Jiralite Jiralite requested review from a team and iCrawl as code owners December 24, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
dependencies packages:discord.js refactor semver:major
Projects
discord.js
Status: Todo
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiralite @almeidx