Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: remove createComponent and createComponentBuilder #10687

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

types: remove createComponent and createComponentBuilder #10687

wants to merge 1 commit into from

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jan 4, 2025 •
edited
Loading

These are not exported in JS land.
Not sure if there's a case for keeping MappedComponentTypes and MappedComponentBuilderTypes

Resolves DJS-58, DJS-59

@almeidx almeidx requested a review from a team as a code owner January 4, 2025 16:33
@vercel Vercel
Copy link

vercel bot commented Jan 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2025 6:13pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2025 6:13pm

@almeidx almeidx added the typings label Jan 4, 2025
@almeidx almeidx added this to the discord.js 15.0.0 milestone Jan 4, 2025
Jiralite
Jiralite reviewed Jan 4, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this still show up in the documentation (old one)? It relies on JSDoc, and it's still documented.

@almeidx almeidx force-pushed the types/remove-create-component-fns branch from 94a17c3 to 8e116f0 Compare January 4, 2025 18:12
@almeidx almeidx requested a review from Jiralite January 4, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Status: Todo
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@almeidx @Jiralite