Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove InteractionResponse #10689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 4, 2025

Please describe the changes this PR makes and why it should be merged:
Removing InteractionResponse, a class that has brought us many pains and bugs (still present) that are difficult or impossible to fix (we go back and forth sometimes). The existing solution is to simply use withResponse, a recent addition to the Discord API, which does not incur an extra API call.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

BREAKING CHANGE: `InteractionResponse` has been removed. Create interaction collectors via `with_response` or fetching the reply.
Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jan 4, 2025 11:00pm
discord-js-guide ⬜️ Ignored (Inspect) Jan 4, 2025 11:00pm

@Jiralite Jiralite changed the title refactor!: remove class refactor!: Remove InteractionResponse Jan 4, 2025
@Jiralite Jiralite marked this pull request as ready for review January 4, 2025 23:10
@Jiralite Jiralite requested a review from a team as a code owner January 4, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant