Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand selection to quotes #24

Closed
ajitid opened this issue Apr 25, 2017 · 5 comments
Closed

Expand selection to quotes #24

ajitid opened this issue Apr 25, 2017 · 5 comments
Labels

Comments

@ajitid
Copy link
Contributor

ajitid commented Apr 25, 2017

VS Code has this nice expand selection feature. While expanding selection, Dracula include quotes (maybe because it gives same color to the quotes) but other themes like Nord and Material Theme (Mattia's one) does not. Everytime when I need to clear out anything inside a quote and replace it with something, putting those quotes again gives me another step. Can you fix that?
drac

@dsifford dsifford added the bug label Apr 25, 2017
@dsifford
Copy link
Member

@ajitid Very strange! Not totally sure why that would be happening, but I'll look into it. Thanks for reporting👍

@dsifford
Copy link
Member

@ajitid Yep, this looks like it's a bug with vscode itself.

Just tried changing the colors of the quotes and it fixes the issue. Could you open an issue with vscode about this?

Scopes of interest:

  • punctuation.definition.string.begin
  • punctuation.definition.string.end

When set to a different color than string, it expands correctly. When set to the same color, it does not.

Thanks a bunch! I'm sure the VSCode guys and gals will also appreciate hearing about this 😄

@ajitid
Copy link
Contributor Author

ajitid commented Apr 25, 2017

Okay I'm putting this issue to VS Code. Will you change the color of quotes in next Dracula update or have I need to wait for VS code team to make changes?

@dsifford
Copy link
Member

Thanks! Let's hold off until we hear back from VSCode.

@ajitid
Copy link
Contributor Author

ajitid commented Apr 26, 2017

They just marked it as a duplicate and closed the issue. The issue for which they marked this one as a duplicate is open for one year. Now what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants