Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand selection doesn't always work with every theme (for quotes) #25344

Closed
ajitid opened this issue Apr 25, 2017 · 1 comment
Closed

Expand selection doesn't always work with every theme (for quotes) #25344

ajitid opened this issue Apr 25, 2017 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@ajitid
Copy link
Contributor

ajitid commented Apr 25, 2017

  • VSCode Version:
  • OS Version: Windows 10

Steps to Reproduce:

  1. Type anything between quotes
  2. Put cursor between the cursor on what you just typed and use expand selection (Alt+Shift+Right Arrow)
  3. Try it first with Dark+ (default) theme or Dracula Theme and then with Mattia Astornio's Material Theme or with Nord theme

Thing to notice: If the quotes are colored as same as text, it includes it in the selection, but it doesn't if it has different color assigned.

ff2de466-29bb-11e7-9230-5e5ff7f0443d

To-do: Expand selection should not include quotes, but just the text because a lot of times we need to change what is inside the quotes only. Putting quotes around the text again will add one step more.

Originally posted on Dracula theme repo, but as it also includes the default Dark+ theme and seems to be like a bug in VS Code itself, which I found a lot of people like and stick to it, so I put it here too.

dracula/visual-studio-code#24 (comment)
(Below one is copied from the link above)
Scopes of interest:

  • punctuation.definition.string.begin
  • punctuation.definition.string.end
    When set to a different color than string, it expands correctly. When set to the same color, it does not.
@ajitid ajitid changed the title Expand selection to quotes Expand selection doesn't work with every theme (for quotes) Apr 26, 2017
@ajitid ajitid changed the title Expand selection doesn't work with every theme (for quotes) Expand selection doesn't always work with every theme (for quotes) Apr 26, 2017
@jrieken
Copy link
Member

jrieken commented Apr 26, 2017

dupe of #4795

@jrieken jrieken closed this as completed Apr 26, 2017
@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants