Fix security issues in dependencies and Studio directly #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
status:conflicts
URL parameters could be used to modify the root prototype, eg.:
?__proto__.toString=peter
Fortunately, the assigned value is always a string, so it's not possible
to overwrite functions with other functions. The example above just
leads to a JS error which is caught by the application and an error is
then displayed. It might be possible to add a new field to the prototype
that then leads to other code checking `if ('foo' in obj)` to behave
differently. But I couldn't find a spot that could be abused. I might
very well have missed something, but my guess would be that this
vulnerability is not really exploitable in a bad way.
Note: I think only one of the `{}` needs to be replaced by
`Object.create(null)`, but it doesn't hurt just replacing all of them.
From a quick glance, I also didn't find any similar problems in the
code base.
This updates a ton of other dependencies. In particular, it also fixes a ton of security issues within the dependency tree.
LukasKalbertodt
force-pushed
the
fix-prototype-pollution
branch
from
431623c to
a65572c
Compare
github-actions
bot
removed
the
status:conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is mainly for the first commit which fixes a prototype pollution issue in Studio. As the commit message says, we couldn't find a way to actually exploit it, so we don't think this is a high impact security issue. It's scary though, so it needs to be fixed for sure. We only found ways to break Studio (but that's not particularly useful to an attacker): https://studio.opencast.org/?__proto__.toString=peter
The other commits are about updating dependencies to get rid of security issues in those.