[Security Solution] EUI Refresh Followup Pt. 1 #205990
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`warningText -> textWarning`. This also replaces some uses of the now-deprecated `euiThemeVars` with use of the `useEuiTheme` hook.
* This uses the theme to set a min-height on the textarea, since it is a best practice with a resizable element. The dropped styles were no longer necessary with the EUI component.
Both box-shadow and border were being applied here, which combined with the border-radius lead to a weird-looking input. This removes the box-shadow.
* Removes uses of deprecated tokens * Aligns EqlQueryBar closer to a normal form component (no custom label)
These were "solved" by using the `useEuiTheme` hook and placing the generation of styles within the component itself, as opposed to statically outside them. In the case of `generateLinkedRulesMenuItems`, the function was a react component in everything but name. I renamed it so that the react-hooks linter rules wouldn't complain, but I left the manual invocations of the element since they're
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first batch of work involving #202052.
The new theme was verified to work as-is with our codebase (#205105), as we were not using any removed/renamed code, but this PR includes the other required tasks, as well as some cleanup of existing styles.
As a majority of these components' usage of theme variables is done with
@styled-components, and we are transitioning away from that toward@emotion, I also opted to remove usages of@styled-componentswherever possible, as that change was negligible in comparison with the theming changes.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.