-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about VMs #625
Warn about VMs #625
Conversation
cassidyjames PR
@cassidyjames sorry I was not aware of #326. Last commit changed the layout based on your PR: |
@meisenzahl shouldn't this be a part of CheckView where we perform other checks before installing? |
@cassidyjames please excuse the confusion with your PR. There is now a warning when it detects that Installer is running in a virtual machine. I took the logic almost 1:1 from your PR. In addition, I have managed to display several warnings one after the other. Peek.2021-12-08.20-20.mp4The checks are not executed for
Let's try to fix this in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this works as intended and that checkview code looks really not fun to work, so thank you for working on this!
Closes #323
Shows a warning as first view if running in a virtualized environment.
Simple solution
Shutdown button
Maybe a bit too much with a suggested shutdown button.