Conversation
|
@cassidyjames Could you maybe test this with LoDPI (e.g. Pinebook Pro) and HiDPI hardware? |
There was a problem hiding this comment.
On my 27" 2560×1440 display, this shows all three options (1x, 2x, and 3x scaling). 2x is debatable, but 3x makes no sense.
I wonder if we should restrict this to showing options for the equivalent of 768 vertical pixels, since that's our minimum supported resolution? So on a 27" 1440p display, we wouldn't show 2x or 3x because 1440/2 = 720, and 1440/3 = 480—far below our supported resolution.
src/Views/DisplaysView.vala
Outdated
| dpi_combo.append_text (_("LoDPI")); | ||
| dpi_combo.append_text (_("Pixel Doubled")); | ||
| dpi_combo.append_text (_("LoDPI") + " (1×)"); | ||
| int max_scale = height / 768; |
There was a problem hiding this comment.
Should probably pull this out into a constant so it's more obvious where it's coming from and what it represents, e.g. MIN_SUPPORTED_HEIGHT
There was a problem hiding this comment.
Hm, now when I use this on a HiDPI laptop with a loDPI external display, the scaling factor option is disabled completely (forced to 1×). I wonder if we should just make sure at least one display or maybe the primary display meets the 768 minimum height when considering the scaling factors?
I'm not sure how this would behave without having a previous display arrangement (I previously manually set my laptop resolution to half and the scaling-factor to 1×), but it would not be fun to accidentally get into a case where your HiDPI laptop was forced to LoDPI because you connected an external display, without it also halving the resolution...
Gah multi-monitor and multi-scaling-factor is so complex to handle all the edge cases 😭
meisenzahl
force-pushed
the
add-3×-scaling-setting
branch
from
1ecde68 to
c88bae4
Compare
|
@cassidyjames this is really dumb now 😁 |
Related to #130