-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor to prevent unnecessary lockfile changes #1120
Conversation
… and add explicit update script to update use w/o frozen lock file option
include the scenarios to not freeze the lockfile
Hey @monilpat, I've already started working on this during weekend myself. See this branch: jure/fix-workflows-and-docs. I even went so far to try to update Chinese etc. READMEs, which is of course complete nonsense since I don't even understand what is written there. Furthermore, there are scripts that use Initially, I had a thought to update all references to The proper solution therefore boils down to PR reviewers. In particular:
That said, the tests can fail for more than lockfile being out of sync, and we should probably focus on making them work in a reliable way. One of key issues is that our tests depend on external things such as OpenAI and API keys. I would recommend adding a separate smoke test just for OpenAI (a simple |
As agreed, adding |
Relates to:
#1121
Risks
Background
What does this PR do?
This PR updates the installation commands across various files to ensure that the
pnpm install
command uses the--frozen-lockfile
option. This prevents the lock file from being incorrectly updated during installations. Additionally, an explicit update script has been added to allow updates without the frozen lock file option. We updated the .npmrc default to set frozen-lockfile=true and in order to update the lockfile when you add a new dependency in your package.json or bump a version in your package.json you need to explicitly call pnpm i --no-frozen-lockfileWhat kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Review the changes made in the following files to understand the impact of the updates:
.github/workflows/pre-release.yml
Dockerfile
package.json
scripts/start.sh
Detailed testing steps
pnpm install
to verify that it respects the frozen lock file.pnpm update
to ensure it updates dependencies correctly without the frozen lock file option.