Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: telegram client duplicate function removal #1140

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

azep-ninja
Copy link
Contributor

Relates to:

N/A

Risks

Low - Removing duplicate function.

Background

What does this PR do?

What kind of change is this?

Bug fix - Removing duplicate _isMessageForMe private function in Telegram messages.ts file.

Documentation changes needed?

N/A

Testing

Where should a reviewer start?

Detailed testing steps

Review messageManager.ts in telegram-client to confirm only 1 private _isMessageForMe now exists with same functionality to avoid issues.

N/A

N/A

N/A

N/A

Copy link

@chrislatorres chrislatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monilpat monilpat merged commit 7d6d121 into elizaOS:develop Dec 16, 2024
3 of 4 checks passed
@azep-ninja azep-ninja deleted the fix/duplicate-tg-funtions branch December 17, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants