clean newlines for new tweet #1141
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlcode
force-pushed
the
clean-newlines-from-new-tweets
branch
from
bdfac09 to
db9580d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
New tweet being created with
\ntext instead of new lineRisks
No risks
Background
What does this PR do?
Improves tweet creation script. Make sure none
\nare inside newly published tweet.What kind of change is this?
Improvement. This logic is already there inside
generateTweetContenthowever it's not included insidegenerateNewTweet. It could use a little more refactor but right now I'm just posting this as an easy fix.Why are we doing this? Any context or related work?
I'm playing around with eliza and my twitter account and saw that it posted tweet with
\n \ninside which I don't think is what AI beneath intended :)Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
I looked at the logs and inserted the cleanup function right before it's submitted to twitter. I'm attaching screenshot from logs to see my reasoning
Where should a reviewer start?
Quite simple change
Detailed testing steps
None, automated tests are fine.
Discord username
elowielo