Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generateNewTweetLoop
was called twice in thestart
method of /packages/client-twitter/src/post.ts.generateNewTweetLoop()
inside theif (enableActionProcessing)
Fixes #1395
Relates to:
Issue #1395
Risks
Low: Removing the redundant call ensures only one scheduling loop, minimal impact on other functionalities.
Background
What does this PR do?
This PR fixes an issue where
generateNewTweetLoop
was called twice, leading multiple tweets to be posted. It ensures only a single scheduling loop is initialized by removing the redundant call.What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
Start by reviewing the
start
method in /packages/client-twitter/src/post.ts, focusing on the moving secondgenerateNewTweetLoop()
inside theif (enableActionProcessing)
condition.Detailed testing steps
POST_IMMEDIATELY=true
to enable immediate tweet posting.Next tweet scheduled in xxx minutes
messages.Next tweet scheduled in xxx minutes
message is logged only once.