fix: Update Key Derive in TEE #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KEK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
Fixes the Key Derive functionality, by using path for reliable key derivation. Subject is documented and commented in code to clarify the use for the certificate chain.
Risks
Low, the risk is low since this does not change existing functionality, but brings more clarity.
Background
Client had a problem with generating new wallets for Solana since the derived key would stay the same even though the subject was changed.
What does this PR do?
This brings clarity on how to use the key derivation function for TEE Plugin and updates the functionality to Solana and EVM chains
What kind of change is this?
Bug fixes, and added unit tests
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps