Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When the plugins field in the .character.json file is configured with plugin name. #784

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

xwxtwd
Copy link
Contributor

@xwxtwd xwxtwd commented Dec 2, 2024

Fix the issue where running the program throws an error when the plugins field in the .character.json file is configured with plugin names.

Relates to:

N/A

Risks

Low.

  1. May impact existing character configurations relying on specific plugin behaviors.

Background

What does this PR do?

This PR fixes an issue where the application would throw an error when the plugins field in the .character.json file was configured with plugin names (strings). The change ensures that plugin names are properly handled during runtime without requiring additional manual configuration.

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Documentation changes needed?

No.
The change aligns the behavior with the expected functionality, so no additional documentation updates are required.

Testing

Where should a reviewer start?

Start by reviewing the changes to the code responsible for loading and processing the plugins field in .character.json.

Detailed testing steps

1.	Create a .character.json file with the plugins field configured as an array of plugin names (e.g., ["pluginA", "pluginB"]).
2.	Start the application and ensure no errors occur during runtime.
3.	Verify that the listed plugins are loaded and functional.
4.	Test with an empty plugins array and verify proper behavior.

… plugins field in the .character.json file is configured with plugin names.
@xwxtwd xwxtwd changed the title fix: Fix the issue where running the program throws an error when the… fix: When the plugins field in the .character.json file is configured with plugin name. Dec 2, 2024
@lalalune lalalune merged commit 5bc6214 into elizaOS:main Dec 2, 2024
1 check passed
dsldsl pushed a commit to dsldsl/eliza that referenced this pull request Dec 7, 2024
…ugins_field

fix: When the plugins field in the .character.json file is configured with plugin name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants