-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add coinbase ERC20, ERC721, and ERC1155 tokenContract deployment / invokement plugin #803
Merged
jkbrooks
merged 5 commits into
elizaOS:main
from
monilpat:realitySpiral/tokenContractPlugin
Dec 4, 2024
Merged
feat: add coinbase ERC20, ERC721, and ERC1155 tokenContract deployment / invokement plugin #803
jkbrooks
merged 5 commits into
elizaOS:main
from
monilpat:realitySpiral/tokenContractPlugin
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t / invokement plugins
monilpat
changed the title
feat: add coinbase ERC20, ERC721, and ERC1155 tokenContract deployment / invokement plugins
feat: add coinbase ERC20, ERC721, and ERC1155 tokenContract deployment / invokement plugin
Dec 3, 2024
pgoos
reviewed
Dec 4, 2024
pgoos
reviewed
Dec 4, 2024
pgoos
reviewed
Dec 4, 2024
pgoos
reviewed
Dec 4, 2024
pgoos
reviewed
Dec 4, 2024
pgoos
reviewed
Dec 4, 2024
pgoos
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @monilpat ! Left a few minor comments. Other than that, LGTM 🚀
jkbrooks
approved these changes
Dec 4, 2024
dsldsl
pushed a commit
to dsldsl/eliza
that referenced
this pull request
Dec 7, 2024
…actPlugin feat: add coinbase ERC20, ERC721, and ERC1155 tokenContract deployment / invokement plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Relates to:
N/A - New feature implementation
Risks
Low - This PR adds new functionality without modifying existing features. The token contract plugin is only enabled when proper Coinbase credentials are present.
Background
What does this PR do?
This PR adds a new Coinbase token contract plugin that enables:
What kind of change is this?
Features (non-breaking change which adds functionality)
Documentation changes needed?
My changes require a change to the project documentation.
docs/docs/packages/plugins.md
Testing
Where should a reviewer start?
Review the token contract plugin implementation:
packages/plugin-coinbase/src/plugins/tokenContract.ts
packages/plugin-coinbase/src/types.ts
(new token contract types)packages/plugin-coinbase/src/templates.ts
(new templates)Review the integration:
agent/src/index.ts
(plugin initialization)packages/plugin-coinbase/src/index.ts
(plugin exports)Detailed testing steps
Configure Coinbase credentials:
Test ERC20 token deployment:
Test ERC721 (NFT) deployment:
Test contract interaction:
Verify CSV logging:
contracts.csv
for deployment recordshttps://drive.google.com/file/d/1q5ezLF6KOgJdQ6x04m_lStiO2Y-jzCEq/view?usp=sharing
https://drive.google.com/file/d/1cFK9RbxTw7GaD3J0sfxva0t4UIuZrmpQ/view?usp=sharing
Files changed:
packages/plugin-coinbase/src/plugins/tokenContract.ts
(new)packages/plugin-coinbase/src/types.ts
(updated)packages/plugin-coinbase/src/templates.ts
(updated)packages/plugin-coinbase/src/index.ts
(updated)agent/src/index.ts
(updated)docs/docs/packages/plugins.md
(updated)Deploy Notes
No special deployment steps required. The plugin is automatically enabled when Coinbase credentials are present.
Discord username
N/A