feat: (core) Add circuit breaker pattern for database operations -… #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augchan42
changed the title
shakkernerd
reviewed
Dec 3, 2024
|
Sorry, added this back in, must have lost it from all the rebases that I
aborted, etc
…On Tue, Dec 3, 2024 at 1:40 PM Shakker Nerd ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/adapter-postgres/src/index.ts
<#812 (comment)>:
> - const client = await this.pool.connect();
- try {
- await client.query("BEGIN");
-
- // Check if schema already exists (check for a core table)
- const { rows } = await client.query(`
- SELECT EXISTS (
- SELECT FROM information_schema.tables
- WHERE table_name = 'rooms'
- );
- `);
-
- if (!rows[0].exists) {
- const schema = fs.readFileSync(
- path.resolve(__dirname, "../schema.sql"),
- "utf8"
- );
- await client.query(schema);
- }
+ const schema = fs.readFileSync(
+ path.resolve(__dirname, "../schema.sql"),
+ "utf8"
+ );
- await client.query("COMMIT");
- } catch (error) {
- await client.query("ROLLBACK");
- throw error;
- } finally {
- client.release();
- }
This check is critical and important.
—
Reply to this email directly, view it on GitHub
<#812 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE32LKPHZINE2FLSIQ66I7L2DU75RAVCNFSM6AAAAABS42PJCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZUGYZDQOJSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It's fine. |
dsldsl
pushed a commit
to dsldsl/eliza
that referenced
this pull request
Dec 7, 2024
…-pattern-v2 feat: (core) Add circuit breaker pattern for database operations -…
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #719
Fixes #712
This PR implements the circuit breaker pattern directly in DatabaseAdapter as discussed in the previous PR.
Implements circuit breaker pattern to handle database failures gracefully and prevent cascading failures. Fixes #712.
Changes:
Adds CircuitBreaker class with CLOSED, OPEN, and HALF-OPEN states
Introduces BaseCircuitBreakerAdapter for database adapters
Configurable failure thresholds and recovery timeouts
Automatic recovery attempts in HALF-OPEN state
Detailed logging of circuit breaker state changes
Circuit breaker configuration:
Opens after 5 consecutive failures (configurable)
Resets after 60 seconds in OPEN state
Requires 3 successful operations in HALF-OPEN state to close
This helps prevent overwhelming failed database connections and provides graceful degradation during outages.