Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart.md #872

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update quickstart.md #872

merged 1 commit into from
Dec 6, 2024

Conversation

oxSaturn
Copy link
Contributor

@oxSaturn oxSaturn commented Dec 6, 2024

Relates to:

Risks

Background

What does this PR do?

I believe the removed statement is wrong, per the code here https://github.com/ai16z/eliza/blob/7fb73d209a5d6d09a039515a088ff14b48691511/packages/client-twitter/src/environment.ts#L4-L12

Both password and email will always be needed even if TWITTER_COOKIES is set.

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkbrooks jkbrooks merged commit 097f1ad into elizaOS:main Dec 6, 2024
2 of 3 checks passed
@oxSaturn oxSaturn deleted the patch-1 branch December 7, 2024 01:18
dsldsl pushed a commit to dsldsl/eliza that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants