fix: use of Heurist model env vars #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxSaturn
reviewed
Dec 9, 2024
shakkernerd
changed the title
shakkernerd
approved these changes
Dec 9, 2024
shakkernerd
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Risks
Low: If the user had previously set these env vars to any value, these will now be used where previously they would be ignored.
Background
What does this PR do?
This PR will make the previously defined Heurist model env vars actually take effect.
What kind of change is this?
Bug fix
Why are we doing this? Any context or related work?
Because the env vars are already defined, and it makes sense to use them.
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
Where should a reviewer start?
The change should be pretty straight forward.
Detailed testing steps