test: adding tests. changed files actions.test.ts, messages.test.ts, models.test.ts #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monilpat
requested changes
Dec 12, 2024
Comment on lines
+41
to
+43
| handler: async () => { throw new Error("Not implemented"); }, | ||
| validate: async () => { throw new Error("Not implemented"); }, | ||
| }, |
There was a problem hiding this comment.
We should probably implement these and test then properly in a follow up PR :)
There was a problem hiding this comment.
Can't wait! :)
|
|
||
| test("should have correct model mappings", () => { | ||
| const openAIModels = models[ModelProviderName.OPENAI].model; | ||
| expect(openAIModels[ModelClass.SMALL]).toBe("gpt-4o-mini"); |
There was a problem hiding this comment.
instead of hardcoding we pay want to use the settings and then default to the hard coded values. As this will change for instance when we add o1 and o1 pro support See https://github.com/ai16z/eliza/pull/999/files#diff-c128c91a940e645cc1d7842bec41d065604fce9e1bbc69dfca3f3d089cac52eb
|
Please update the PR to be against develop and not main |
|
Changed base to develop @monilpat |
odilitime
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
No particular issue, adding more coverage and more tests for actions.test.ts, messages.test.ts, models.test.ts to cover more functionalities.
Risks
Low, adding tests.
Background
What does this PR do?
This PR adds more tests to already existing test suites.
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
packages/core/src/tests/
Detailed testing steps
navigate to packages/core and run pnpm install and pnpm test