Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu button with text and image #4748

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Add a menu button with text and image #4748

merged 7 commits into from
Jul 9, 2024

Conversation

NicolasBircksZR
Copy link
Contributor

In order to make it possible that all buttons can have the same style with a text and an image I created a menu_text_image_button.

It works the same way as all the other menu buttons.

crates/egui/src/ui.rs Outdated Show resolved Hide resolved
@NicolasBircksZR NicolasBircksZR requested a review from emilk July 1, 2024 18:36
crates/egui/src/menu.rs Outdated Show resolved Hide resolved
crates/egui/src/menu.rs Outdated Show resolved Hide resolved
@NicolasBircksZR NicolasBircksZR requested a review from emilk July 2, 2024 10:55
crates/egui/src/ui.rs Outdated Show resolved Hide resolved
Co-authored-by: Emil Ernerfeldt <[email protected]>
@NicolasBircksZR
Copy link
Contributor Author

@emilk Updated it - does this work now as you wanted?

crates/egui/src/ui.rs Outdated Show resolved Hide resolved
crates/egui/src/menu.rs Show resolved Hide resolved
@NicolasBircksZR NicolasBircksZR requested a review from emilk July 9, 2024 08:31
@emilk emilk added the egui label Jul 9, 2024
@emilk emilk merged commit 3b8453e into emilk:master Jul 9, 2024
19 of 20 checks passed
@emilk
Copy link
Owner

emilk commented Jul 9, 2024

Thanks!

486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
In order to make it possible that all buttons can have the same style
with a text and an image I created a `menu_text_image_button`.

It works the same way as all the other menu buttons.

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
In order to make it possible that all buttons can have the same style
with a text and an image I created a `menu_text_image_button`.

It works the same way as all the other menu buttons.

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants