Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't interact with Area outside its constrain_rect #5459

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

MScottMcBee
Copy link
Contributor

@MScottMcBee MScottMcBee commented Dec 10, 2024

  • I have followed the instructions in the PR template

This PR makes an area's interact rect intersect its constrain rect. This fixes an issue where masked areas would still intercept input.

Before:
before

After:
after

@MScottMcBee MScottMcBee marked this pull request as ready for review December 10, 2024 22:40
@emilk emilk added bug Something is broken egui labels Dec 12, 2024
@emilk emilk changed the title Intersect Area interact_rect with constrain_rect Fix: don't interact with Area outside its constrain_rect Dec 12, 2024
@emilk
Copy link
Owner

emilk commented Dec 12, 2024

Nice one

Copy link

Preview available at https://egui-pr-preview.github.io/pr/null
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk emilk merged commit d3ea922 into emilk:master Dec 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants