-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shim for Function::bind throws error for non-minified React #390
Comments
Thank you for the jsbin - I'll take a look at this this weekend and see if I can figure it out. What's likely happening is that the non-minified version is triggering the regex in |
Thanks. Let me know if there's anything I can do to help. |
Just leaving a note here to follow this issue, having the same issue in our project (We think from f2236f6) getting |
I've confirmed this on actual WinXP/IE8 as well for unminified versions (yes, my team really does support this configuration...fortunately only dev builds on not minified) |
Thanks everybody! I promise I'll have a fix out this weekend. |
You da man @ljharb! |
Figured out the issue in |
Released as v4.5.7 |
Confirming that issue has been fixed. Thanks @ljharb! |
thanks @ljharb -- confirmed on ye olde xp machine |
I apologize if this is reported elsewhere, or if it's the intended behavior, or not es5-shim's fault (which it probably isn't), but I can't be the only one dealing with this!
The problem is that this throws an error in IE8:
As far as I can tell, this is because of this code:
Now, es5-shim uses isCallable to determine if something can be
bind
ed.For some reason,
mixSpecIntoComponent
fails theisCallable
test, in particular because it passes theisES6ClassFn(value)
test, thusthrow
ing this error.What gives?
Strangely, the problem does not occur when using the minified version.
Note FWIW: I'm testing this on IE8 on Win7 via VirtualBox VM from a MBP
Thank you so much for this awesome lib!
The text was updated successfully, but these errors were encountered: