Add reverse-string exercise, including support for unicode package #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ageron
force-pushed
the
add-reverse-string
branch
from
9c90634 to
daee56f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
reverse-stringexercise. This involved using theunicodepackage, which required tweakinggenerate_macros.j2to make it possible to add external packages.Note that there seems to be an issue in the
unicodepackage which makesGrapheme.splitfail on empty strings (see #15), so I had to explicitely handle that case separately. Once the issue is resolved, I'll remove this test.I also included an ASCII-only implementation, which is simpler and doesn't require an external package, but does not support non-ASCII characters.