Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concept-exercises-test-upgrades]: Updated tests in the concept exercises using not deprecated functionality. #143

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SimaDovakin
Copy link
Contributor

No description provided.

@SimaDovakin SimaDovakin requested a review from rlmark November 12, 2024 19:55
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@SimaDovakin SimaDovakin requested a review from a team November 12, 2024 20:17
@SimaDovakin
Copy link
Contributor Author

@rlmark Hi! Could we merge it, please?

Copy link
Contributor

@rlmark rlmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you so much! I ran this locally using the .bin/test script and verified that the tests were able to run via the transcripts.

@rlmark rlmark merged commit 1172280 into main Jan 7, 2025
3 checks passed
@rlmark rlmark deleted the concept-exercises-test-upgrades branch January 7, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants