-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition breaking changes #72
Comments
Ooops! You're right. I'll fix it ASAP
Fatih Kadir Akın
27 May 2019 Pzt 22:33 tarihinde Kristina Demeshchik <
[email protected]> şunu yazdı:
… Hey!
First of all, I wanna thank you for such a good job you're doing!
The problem I wanna draw your attention to is about transition after you
introduced the transition element our application got broken. So here's the
thing, if we send multiple elements as content for v-wait, Vue is
complaining about multiple elements inside of transition and asking to
use transition-group instead.
We can easily fix it by wrapping content into div, but as long as it's
something that pretty hard to debug, you might want to do it on vue-wait
side
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#72?email_source=notifications&email_token=AABP67O534OEHKMMG56OLFTPXQZPRA5CNFSM4HP6BMP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWCZA3Q>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABP67N5Z3OBC67U62QDGJLPXQZPRANCNFSM4HP6BMPQ>
.
|
Hi I've fixed it and released with v1.4.6. Thank you! Can you please test it and close the issue if it's resolved. |
Wow that was quick 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey!
First of all, I wanna thank you for such a good job you're doing!
The problem I wanna draw your attention to is about transition. After you introduced the transition element our application got broken. So here's the thing, if we send multiple elements as content for
v-wait
, Vue is complaining about multiple elements inside oftransition
and asking to usetransition-group
instead.We can easily fix it by wrapping content into
div
, but as long as it's something that pretty hard to debug, you might want to do it onvue-wait
sideThanks!
The text was updated successfully, but these errors were encountered: