chore: add eslint unicorn plugin #213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for valibot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I will review this PR after we merged #202. |
fabian-hiller
force-pushed
the
main
branch
7 times, most recently
from
b997a0f to
6d0cde4
Compare
fabian-hiller
force-pushed
the
main
branch
5 times, most recently
from
41ae798 to
4a7ee57
Compare
fabian-hiller
force-pushed
the
main
branch
2 times, most recently
from
7a97dd0 to
b5f7f4d
Compare
|
FYI, |
|
Good point. I think we briefly discussed that back then and preferred having one rule over many that improve regexps, but if it contains bugs, we should go for eslint-plugin-regexp (at Framer we're also using that). Wdyt Fabian? |
|
I think you can decide that better. Feel free to create a PR and improve our current setup. |
fabian-hiller
force-pushed
the
main
branch
2 times, most recently
from
f41426c to
d713dfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #202.
Unicorn really brings some advantages, such as auto optimizing regexps (makes them smaller) and sets rules for writing or using regexps in the most efficient way. https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-reduce.md?rgh-link-date=2023-10-07T09%3A37%3A41Z might also be interesting (for e.g. #203)