Skip to content

Commit

Permalink
Remove position type override on scroll view sticky headers (#47498)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #47498

I am trying to help someone with creating a sticky header on a scrollview, specifically one that floats on the side of the scrollview instead of the top Currently we can't really do that, since utilizing `position: absolute` to layout this properly will get overriden by the header styles changed in this diff

This was only added since static was the default and we needed to apply zIndex. With proper static implementation that is no longer the case, so I think it makes sense to remove this to support this use case.

Changelog: [General] [Breaking] - `position` of sticky headers on `ScrollView` will now be taken into account

Reviewed By: rozele

Differential Revision: D65626544

fbshipit-source-id: 8d650ca7654918e692435935e7c1094c412fd9f6
  • Loading branch information
joevilches authored and facebook-github-bot committed Nov 8, 2024
1 parent 846c4b1 commit cbab004
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@ const ScrollViewStickyHeaderWithForwardedRef: component(
const styles = StyleSheet.create({
header: {
zIndex: 10,
position: 'relative',
},
fill: {
flex: 1,
Expand Down

0 comments on commit cbab004

Please sign in to comment.