Convert + Internalize SwipeRefreshLayoutManager #47470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65481861 |
|
This pull request was exported from Phabricator. Differential Revision: D65481861 |
tdn120
pushed a commit
to tdn120/react-native
that referenced
this pull request
Nov 7, 2024
Summary: Pull Request resolved: facebook#47470 Convert to Kotlin and formalize it being an internal class (some methods were already `protected` in Java) Changelog: [Android] [Breaking] - Stable API - Make SwipeRefreshLayoutManager internal Reviewed By: cortinico Differential Revision: D65481861
tdn120
force-pushed
the
export-D65481861
branch
from
0210601 to
8e66c27
Compare
Summary: Pull Request resolved: facebook#47470 Convert to Kotlin and formalize it being an internal class (some methods were already `protected` in Java) Changelog: [Android] [Breaking] - Stable API - Make SwipeRefreshLayoutManager internal Reviewed By: cortinico Differential Revision: D65481861
tdn120
force-pushed
the
export-D65481861
branch
from
8e66c27 to
2e8292c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65481861 |
|
This pull request has been merged in d02da99. |
|
This pull request was successfully merged by Thomas Nardone in d02da99 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Convert to Kotlin and formalize it being an internal class (some methods were already
protectedin Java)Changelog:
[Android] [Breaking] - Stable API - Make SwipeRefreshLayoutManager internal
Reviewed By: cortinico
Differential Revision: D65481861