RN: Enable scheduleAnimatedEndCallbackInMicrotask
#47503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65645981 |
…acebook#47502) Summary: Enables the two following feature flags: - `enableAnimatedAllowlist` - `enableAnimatedPropsMemo` The former enables the use of an experimental optimization to provide `unstable_createAnimatedComponentWithAllowlist` and `useAnimatedProps` an allowlist of props that reduces the set of props iterated over by to find props with `AnimatedNode` (e.g. `Animated.Value`) instance values. The latter enables improved memoization logic in `Animated` so that its intenal state is invalidated less frequently, reducing the cost of updating `Animated` components. Changelog: [General][Changed] - Optimized the performance of updating `Animated` components. Reviewed By: rozele Differential Revision: D65645985
Summary: Enables the `scheduleAnimatedEndCallbackInMicrotask` feature flag that was introduced in facebook#46714. Changelog: [General][Changed] - Callbacks passed to `animation.start(<callback>)` will be scheduled for execution in a microtask. Previously, there were certain scenarios in which the callback could be synchronously executed by `start`. Differential Revision: D65645981
yungsters
force-pushed
the
export-D65645981
branch
from
560454e to
54e69cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65645981 |
|
This pull request has been merged in 090501d. |
|
This pull request was successfully merged by @yungsters in 090501d When will my fix make it into a release? | How to file a pick request? |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Dec 6, 2024
Summary: Backs out D63573322 and D65645981, reverting the change that makes callbacks passed to `animation.start(<callback>)` scheduled for execution in a microtask. This is being reverted becuase the latency introduced by the current macro and pending micro tasks can introduce visible latency artifacts that diminish the fidelity of animations. Changelog: [General][Reverted] - Reverts facebook#47503. (~~Callbacks passed to `animation.start(<callback>)` will be scheduled for execution in a microtask. Previously, there were certain scenarios in which the callback could be synchronously executed by `start`.~~) Differential Revision: D66852804
This was referenced Dec 6, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Summary: Pull Request resolved: #48132 Backs out D63573322 and D65645981, reverting the change that makes callbacks passed to `animation.start(<callback>)` scheduled for execution in a microtask. This is being reverted becuase the latency introduced by the current macro and pending micro tasks can introduce visible latency artifacts that diminish the fidelity of animations. Changelog: [General][Changed] - Reverts #47503. (~~Callbacks passed to `animation.start(<callback>)` will be scheduled for execution in a microtask. Previously, there were certain scenarios in which the callback could be synchronously executed by `start`.~~) Reviewed By: javache Differential Revision: D66852804 fbshipit-source-id: 08434b9876813fe9e8b189b6b467198933843bf0
blakef
pushed a commit
that referenced
this pull request
Dec 9, 2024
Summary: Pull Request resolved: #48132 Backs out D63573322 and D65645981, reverting the change that makes callbacks passed to `animation.start(<callback>)` scheduled for execution in a microtask. This is being reverted becuase the latency introduced by the current macro and pending micro tasks can introduce visible latency artifacts that diminish the fidelity of animations. Changelog: [General][Changed] - Reverts #47503. (~~Callbacks passed to `animation.start(<callback>)` will be scheduled for execution in a microtask. Previously, there were certain scenarios in which the callback could be synchronously executed by `start`.~~) Reviewed By: javache Differential Revision: D66852804 fbshipit-source-id: 08434b9876813fe9e8b189b6b467198933843bf0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables the
scheduleAnimatedEndCallbackInMicrotaskfeature flag that was introduced in #46714.Changelog:
[General][Changed] - Callbacks passed to
animation.start(<callback>)will be scheduled for execution in a microtask. Previously, there were certain scenarios in which the callback could be synchronously executed bystart.Differential Revision: D65645981