Skip hidden folders when looking for third party components #48182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66959345 |
…#48182) Summary: Maintainers from SVG reached out because of an edge case they inencountered when generating the ComponentProvider. In their setup, they had a `.git` folder in the repo and the algorithm was spending a lot of time crawling the git folder. In general, we should avoid crawling hidden folders. This change fix that. ## Changelog: [Codegen][Fixed] - Skip hidden folders when looking for third party components. Differential Revision: D66959345
cipolleschi
force-pushed
the
export-D66959345
branch
from
db48d9e to
7795bf1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66959345 |
|
This pull request has been merged in 8ab5243. |
|
This pull request was successfully merged by @cipolleschi in 8ab5243 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
Dec 16, 2024
Summary: Pull Request resolved: #48182 Maintainers from SVG reached out because of an edge case they inencountered when generating the ComponentProvider. In their setup, they had a `.git` folder in the repo and the algorithm was spending a lot of time crawling the git folder. In general, we should avoid crawling hidden folders. This change fix that. ## Changelog: [General][Fixed] - Skip hidden folders when looking for third party components. Reviewed By: javache Differential Revision: D66959345 fbshipit-source-id: 992a79f3cff22cd6a459e0272c8140bc329888da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Maintainers from SVG reached out because of an edge case they inencountered when generating the ComponentProvider. In their setup, they had a
.gitfolder in the repo and the algorithm was spending a lot of time crawling the git folder.In general, we should avoid crawling hidden folders.
This change fix that.
Changelog
[Codegen][Fixed] - Skip hidden folders when looking for third party components.
Differential Revision: D66959345