Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[react-devtools-shell]: disable warnings in dev server overlay #32005

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Jan 7, 2025

Disables warnings Webpack DevServer overlay, which is used by React DevTools shell.

We are testing against react-native-web in this shell, and it installs older versions of the react-dom package, and there are some expected discrepancies between it and react-dom from source.

Before:
Screenshot 2025-01-07 at 12 50 21

After:
Screenshot 2025-01-07 at 12 49 47

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:53am

@vzaidman
Copy link
Contributor

vzaidman commented Jan 8, 2025

too bad there's no way to ignore only certain warnings using a regex, but this is not crucial IMO.

@hoxyq hoxyq merged commit 4268726 into facebook:main Jan 8, 2025
188 of 189 checks passed
@hoxyq hoxyq deleted the react-devtools/disable-warnings-in-webpack-overlay branch January 8, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants