-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Software headers more responsive #25212
base: main
Are you sure you want to change the base?
Conversation
@RachelElysia I'm seeing the same test failure locally what is in CI. I'll review once that's fixed. |
532c734
to
1f2d88e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25212 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 1616 1616
Lines 153836 153847 +11
Branches 3976 4035 +59
=======================================
+ Hits 98230 98240 +10
- Misses 47792 47796 +4
+ Partials 7814 7811 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions are for my understanding, and to ensure we have a comprehensive test plan for this including regressions. So there's a solid chance once those Q's are answered I can approve this with no code changes :)
</div> | ||
)} | ||
<div className="stackable-header top-shift-header"> | ||
{customControl ? customControl() : undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing there's a good reason I should be aware of for the future for why we aren't using the &&
syntax here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope! >.<
frontend/pages/SoftwarePage/SoftwareTitles/SoftwareTable/SoftwareTable.tsx
Show resolved
Hide resolved
helpText: | ||
"Vulnerabilities that have been actively exploited in the wild.", | ||
tooltipContent: !isPremiumTier && disabledTooltipContent, | ||
tooltipContent: !isPremiumTier ? disabledTooltipContent : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same Q here of swithing from &&
to the-construct-golang-is-missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed! ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue
For #24512
Description
Other
<Dropdown/>
that uses outdated react select 1.3.0 to<DropdownWrapper/>
which uses react select 5.4.0Screenshots of fixes
Screenshot of fleet free still behaving as expected
Checklist for submitter
If some of the following don't apply, delete the relevant line.