Create toggle switch component #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure what the flakey test is about. otherwise everything looks good to me, but we should investigate that failure. could just need a rebase? or it could require some changes to the customer resource page object |
cherewaty
reviewed
Oct 19, 2017
| @@ -0,0 +1 @@ | |||
| *.js text eol=lf | |||
There was a problem hiding this comment.
This makes line endings sane on Windows (so it's not trying to convert them into CRLF): microsoft/vscode#2957
cherewaty
force-pushed
the
cg-toggle-packagetitle
branch
from
30cd158 to
0ff86e4
Compare
sadatay
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Customer Resource Selected Toggle by moving it into a separate component and adding animation as shown below:
http://g.recordit.co/WOGSDUvzrr.gif