Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a test explorer for scenarios #42

Closed
zabil opened this issue Nov 16, 2017 · 13 comments
Closed

Implement a test explorer for scenarios #42

zabil opened this issue Nov 16, 2017 · 13 comments
Assignees
@riju91

Comments

@zabil
Copy link
Member

zabil commented Nov 16, 2017

Use the Explorer feature is VS code to implement a test explorer.
For e.g. refer Gitlens plugin

testexploere

  • The pane must list all the Specifications (sorted by scenario heading). It must have a search and filter. The search must be fuzzy
  • Clicking on the Specification must open the specification in the editor.
  • The Specification can be run from the explorer
@zabil zabil added the ready label Nov 16, 2017
@sriv sriv added in progress and removed ready labels Nov 17, 2017
sriv added a commit to getgauge/gauge that referenced this issue Nov 17, 2017
@sriv
add gauge/specs request support to list all specs, getgauge/gauge-vsc…
dc1c93c 
…ode#42
sriv added a commit to getgauge/gauge that referenced this issue Nov 21, 2017
@sriv
add gauge/specs request support to list all specs, getgauge/gauge-vsc…
f61db89 
…ode#42
@sriv sriv mentioned this issue Nov 21, 2017
Merged
nehashri pushed a commit to getgauge/gauge that referenced this issue Nov 24, 2017
@sriv @nehashri
Vscode test explorer support (#870)
b87a520 
* add gauge/specs request support to list all specs, getgauge/gauge-vscode#42

* getAllScenarios should fall back on disk when file isn't in cache

* added tests for getSpecs/getScenarios - LSP

* fixed merge issues

* use specs cache from infoProvider instead of parsing files again for gauge/specs

* use scenarios from specsCache for gauge/scenarios

* send nil error for unknown requests, avoid noise
sriv added a commit that referenced this issue Dec 1, 2017
@sriv
test explorer first cut, #42
87a948e
sriv added a commit that referenced this issue Dec 1, 2017
@sriv
populate test explorer with response from gauge, #42
d23c64e
sriv added a commit that referenced this issue Dec 1, 2017
@sriv
file navigation from explorer now works, #42
812ba60
sriv added a commit that referenced this issue Dec 1, 2017
@sriv
wire up execution command for specs/scenario in explorer, #42
56697c6
sriv added a commit that referenced this issue Dec 1, 2017
@sriv
fix refresh command , #42
181bd20
sriv added a commit that referenced this issue Dec 4, 2017
@sriv
test explorer first cut, #42
2f93ac7
sriv added a commit that referenced this issue Dec 4, 2017
@sriv
populate test explorer with response from gauge, #42
a83f6d4
sriv added a commit that referenced this issue Dec 4, 2017
@sriv
file navigation from explorer now works, #42
fedb73e
sriv added a commit that referenced this issue Dec 4, 2017
@sriv
wire up execution command for specs/scenario in explorer, #42
71ba5e8
sriv added a commit that referenced this issue Dec 4, 2017
@sriv
fix refresh command , #42
72a24c0
sriv added a commit that referenced this issue Dec 4, 2017
@sriv
add flag to toggle gauge specs explorer, #42
5605543
@sriv sriv mentioned this issue Dec 4, 2017
Merged
@zabil
Copy link
Member Author

zabil commented Dec 18, 2017

  • Can we refresh the test explorer on save to avoid the test explorer pane going out of sync?
  • Can we add a find icon that will popup search for symbols when command when clicked?

@riju91 riju91 self-assigned this Jan 12, 2018
riju91 added a commit that referenced this issue Jan 15, 2018
@riju91
Run scenarios fixed for spec explorer #42
884c2d8
riju91 added a commit that referenced this issue Jan 15, 2018
@riju91
Adding Run all specifications button in gauge spec explorer #42
9703cd1
Apoorva-GA added a commit that referenced this issue Jan 16, 2018
@Apoorva-GA
Merge pull request #89 from getgauge/42_specExplorer
1feb9f8 
Run scenarios fixed for spec explorer #42
@sswaroopgupta
Copy link
Contributor

When does the test explorer open? - On which action
How can I open it manually?

@sriv
Copy link
Member

sriv commented Jan 16, 2018

@sguptatw you need to set gauge.specExplorer.enabled=true. By default test explorer is hidden.

@Apoorva-GA
Copy link
Contributor

Text explorer is visible by default now. We have made this change as part of this commit.

@riju91
Copy link
Contributor

riju91 commented Jan 17, 2018

it should be available in nightly >= 2017-01-16

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jan 17, 2018 •
edited
Loading

Issue
Change and save the specification heading should reflect in the test explorer

Expected behavior
If the spec file is saved after changing the specification heading, the change should reflect in the test explorer.

Actual behavior
User settings - "files.autoSave": "afterDelay"
Explicitly save the specification and close it. The test explorer does not refresh.

Should any other settings be enabled?

Note: Explicitly refreshing the test explorer shows the changes

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jan 17, 2018 •
edited
Loading

Issues

@sswaroopgupta
Copy link
Contributor

Expected behavior
In the test explorer, I cannot select multiple scenarios. Right click on a scenario displayed in the test explorer should say Run Scenario

Actual behavior
It says Run Scenarios

Version
gauge-0.0.4.nightly-2018-01-16

@sswaroopgupta
Copy link
Contributor

sswaroopgupta commented Jan 17, 2018 •
edited
Loading

Questions

  • Is Search and filter functionality out of scope of this story?
  • Currently on run, can we display which project is getting executed?

Questions w.r.t Usability

  • When a file of a given project is opened, can the test explorer show the corresponding project? Show an empty list if it is a non-gauge project.
  • The file selection on the file explorer is not in sync with the gauge specs being displayed in the test explorer. What is the expected behavior?

@zabil
Copy link
Member Author

zabil commented Jan 29, 2018

Is Search and filter functionality out of scope of this story?

Yes, this will be handled separately

@sswaroopgupta
Copy link
Contributor

@riju91 - Can multiple select of specifications/scenarios will be handled?

@sswaroopgupta
Copy link
Contributor

Created an issue for Search in Test explorer - #121

@sriv sriv removed their assignment Feb 5, 2018
@riju91
Copy link
Contributor

riju91 commented Feb 5, 2018

@sguptatw It seems that vscode has closed microsoft/vscode#1023 which means they have added a multi select. We need to explore if that is added to extension API as well

@riju91 riju91 mentioned this issue Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riju91 riju91

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zabil @sriv @riju91 @sswaroopgupta @Apoorva-GA