Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of bounds context for short scripts #58

Conversation

willhcr
Copy link
Contributor

@willhcr willhcr commented Oct 16, 2024

Add test case coverage for issue

These changes are under MIT license terms

…n either direction

Add test case coverage for issue
@willhcr willhcr changed the title Limit pre and post context by calculating number of lines available Fix out of bounds context for short scripts Oct 16, 2024
@bruno-garcia bruno-garcia requested a review from vaind October 20, 2024 05:49
@@ -77,6 +78,31 @@
# A module-based frame should be in-app=false
$frames | Where-Object -Property Module | Select-Object -First 1 -ExpandProperty 'InApp' | Should -Be $false
}

$checkShortErrorRecord = {

Check warning

Code scanning / PSScriptAnalyzer

The variable 'checkShortErrorRecord' is assigned but never used. Warning test

The variable 'checkShortErrorRecord' is assigned but never used.
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@vaind vaind merged commit 51d4246 into getsentry:main Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants