gtk: implement dropping files and strings #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
c5053f6 to
5663d63
Compare
|
Note, there seem to be some oddities with how Firefox and Chrome (and Chrome-based Electron apps) do drag and drop as I haven't been able to get those working yet. Firefox and/or GTK seems to be broken because I can't drag a text selection from Firefox to the Gnome Text Editor either. |
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
5663d63 to
457fa11
Compare
mitchellh
requested changes
Jan 2, 2025
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
457fa11 to
0442bd7
Compare
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
0442bd7 to
18d3cbf
Compare
tristan957
reviewed
Jan 7, 2025
|
From my perspective this looks good to go. |
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
18d3cbf to
453e89c
Compare
|
OK, this should be ready to go! |
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
453e89c to
e7c71df
Compare
mitchellh
requested changes
Jan 8, 2025
jcollie
force-pushed
the
gtk-drag-and-drop
branch
from
1b43ec9 to
c85c277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dropping files and strings onto Ghostty in the GTK apprt. If you drop files onto Ghostty it will be pasted as a list of shell-escaped paths separated by newlines. If you drop a string onto Ghostty it will paste the string. Normal rules for pasting (bracketed pasts, unsafe pastes) apply.