fix(gtk): add close confirmation for tabs #4235
Open
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
reviewed
Dec 31, 2024
src/apprt/gtk/Tab.zig
Outdated
| .split => |s| check(s.top_left) or check(s.bottom_right), | ||
| }; | ||
| } | ||
| }.check; |
There was a problem hiding this comment.
I'm aware of this pattern but its not something we generally do within this project.
I don't think we need to wrap this in a struct at all and can just make it a top-level (non-pub) fn.
leigholiver
force-pushed
the
leigh/gtk-confirm-close
branch
from
63e99ee to
3892d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the discord this bit of feedback came up from here
This PR adds confirmation to the places where tabs are closed directly
Fixes: #4234