core: add iterator to handle XDG_*_DIRS #4584
Open
+81
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
reviewed
Jan 4, 2025
mitchellh
requested changes
Jan 4, 2025
There was a problem hiding this comment.
Looking at this, the API doesn't feel right.
A major issue is posix requires allocation. Posix getenv doesn't require allocation so we shouldn't force allocation for this either. Since we have to call this in the config loading path too, lowering allocation as much as possible is a win.
Bigger picture, I know I said this iterator would be helpful, but I'm not fully sure. I know I like small PRs but I'm not actually sure this is the right design. I'm not sure I could know the right design without doing it myself but I'm suspicious looking at this...
jcollie
force-pushed
the
xdg-config-dirs-iterator
branch
from
c4537ff to
7107e86
Compare
jcollie
force-pushed
the
xdg-config-dirs-iterator
branch
from
7107e86 to
2146de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of implementing #4506 .