gtk: unify Wayland and X11 platforms, implement background blur for KDE X11 #4723
+445
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluiedev
force-pushed
the
push-ooptpvywwmwq
branch
from
fd1780e to
72a10c8
Compare
jcollie
suggested changes
Jan 6, 2025
mitchellh
requested changes
Jan 6, 2025
src/apprt/gtk/App.zig
Outdated
| @@ -36,8 +36,7 @@ const c = @import("c.zig").c; | |||
| const version = @import("version.zig"); | |||
| const inspector = @import("inspector.zig"); | |||
| const key = @import("key.zig"); | |||
| const x11 = @import("x11.zig"); | |||
| const wayland = @import("wayland.zig"); | |||
| const platform = @import("platform.zig"); | |||
There was a problem hiding this comment.
I'll just put this right at the beginning since it's everywhere: I'm not sure if "platform" is the right noun for this. Platform is a catch-all of a pluggable thing (similar to widget or plugin or extension). But I feel like in this case there's probably a better noun to describe what we're actually abstracting.
For example, is it:
- Windowing protocol
- Display server
- etc.
(Making those one word is harder...)
But this is pretty core to things so I'd like to make sure we get this right.
There was a problem hiding this comment.
I like "protocol". Calling it "backend" like GTK/GDK does feels okay though that might be confused for app runtimes
src/apprt/gtk/platform.zig
Outdated
| gdk_display: *c.GdkDisplay, | ||
| derived_config: DerivedConfig, | ||
|
|
||
| inner: union(enum) { |
There was a problem hiding this comment.
Bikeshed: name this whatever we decide on for "platform"
pluiedev
force-pushed
the
push-ooptpvywwmwq
branch
from
72a10c8 to
6ad0675
Compare
pluiedev
force-pushed
the
push-ooptpvywwmwq
branch
from
6ad0675 to
f253c14
Compare
pluiedev
force-pushed
the
push-ooptpvywwmwq
branch
from
f253c14 to
ab823cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4626. Please let me know if the architecture looks alright — I'm fairly convinced that I'm being unorthodox here.