-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New styles #83
New styles #83
Conversation
@gillesdemey What do you think about the changes? |
I'll need some time to check out the branch, liking the sass variables so far! |
@gillesdemey Been about a week? No 🎲 ? |
It doesn’t work for me… I just get a window |
@Hum4n01d did you build it right? |
Oops |
No; I ran |
You might need to npm install first |
Maybe the problem is that I |
https://www.dropbox.com/s/cn1k3yd5240hkus/Screenshot%202017-02-06%2021.23.02.png?dl=0 It works fine for me when I packaged it. |
Yeah it uses npm, never worked with yarn before |
Ah ok |
Still doesn’t work though |
I ran
|
thats weird. All this branch edits is the styles. @gillesdemey ? |
Hey @Hum4n01d, this looks like a problem related to Electron/Chromium rather than Cumulus. Can you check if you can launch other Electron apps on your system? What version of Electron are you using? |
@seppestas Ok, I'll check when I get a chance |
I does sounds like something rather related to Electron; FWIW I can build it on my local system and the style changes shouldn't impact anything in particular. Merging this for now and will create a new release — thanks for the hard work (and the patience) 👍 |
Released as v0.10.0 |
Yay! |
Sweeeeeet! :D thanks @gillesdemey Glad you liked the update! |
Let me know if there is anything else I can help with! |
Should be a lot easier to compare changes now, sorry about that.