ls-files: add support for reference range #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk2204
reviewed
Aug 9, 2019
docs/man/git-lfs-ls-files.1.ronn
Outdated
|
|
||
| ## DESCRIPTION | ||
|
|
||
| Display paths of Git LFS files that are found in the tree at the given | ||
| reference. If no reference is given, scan the currently checked-out branch. | ||
| If two references are given, the LFS files that are modified between the two | ||
| references are shown. |
There was a problem hiding this comment.
It looks like your test checks that we don't print deletions. That's fine, but we probably want to mention it here, since Git considers a deletion to be a modification. Maybe add a semicolon and “deletions are not listed”?
There was a problem hiding this comment.
Sounds good! What do you prefer, that I create a new commit or amend the original commit?
There was a problem hiding this comment.
If you could amend the original commit, that would be great.
Teach the ls-files command to show the modified LFS files in a specified commit range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to the
ls-filescommand where the user can specify a commit range. This will return all the lfs files which changed between those two commits.This change is based on the aborted pull request #3151 by @larsxschneider. I finished implementation and added unit tests and documentation.
As background information, the reason for this option is that I have a script that creates a git bundle. To workaround the missing bundle support in lfs (see #1755), I want to know which lfs objects were changed/created in the commit range of the bundle. Currently, in the script, I walk over all commits in the range and do a compare of the
ls-filesoutput. This is very slow however, so ifls-fileshas support for a commit range that would help me a lot.