C++: Support concept templates #18362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
jketema
force-pushed
the
jketema/template-parameters-4
branch
2 times, most recently
from
36d52bf to
9037594
Compare
jketema
force-pushed
the
jketema/template-parameters-3
branch
2 times, most recently
from
96bc406 to
94909ce
Compare
jketema
force-pushed
the
jketema/template-parameters-4
branch
from
9037594 to
e236ce3
Compare
jketema
force-pushed
the
jketema/template-parameters-3
branch
2 times, most recently
from
9f8a8c6 to
8e66019
Compare
jketema
force-pushed
the
jketema/template-parameters-4
branch
3 times, most recently
from
2336e4e to
c843bfa
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (5)
- cpp/downgrades/68744d108e523bdac4e8562cf1aed0169aa69502/upgrade.properties: Language not supported
- cpp/ql/lib/semmle/code/cpp/Concept.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/Declaration.qll: Language not supported
- cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
- cpp/ql/lib/upgrades/4813509d85b45ae17421c036905199f7324cf228/upgrade.properties: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
jketema
commented
Jan 6, 2025
cpp/ql/lib/semmlecode.cpp.dbscheme
Outdated
| int arg_type: @type ref | ||
| ); | ||
| concept_template_argument_value( | ||
| int type_id: @concept ref, |
There was a problem hiding this comment.
Suggested change
| int type_id: @concept ref, | |
| int concept_id: @concept ref, |
There was a problem hiding this comment.
Fixed (through force push).
jketema
force-pushed
the
jketema/template-parameters-4
branch
from
c843bfa to
0f5b70a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).