Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby, Rust: upgrade all cargo dependencies (excluding rust-analyzer) #18441

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jan 8, 2025

The rust-analyzer update will need more work as it seems to break rust analysis on windows.

This was carried out using cargo upgrade from cargo-edit:

  • getting exclusions options for rust-analyzer with
    cargo upgrade -i --dry-run | grep -o 'ra_ap_\S\+' | sort -u | sed 's/^/--exclude=/' > /tmp/exclude
  • running
    cargo upgrade -i $(cat /tmp/exclude)
    misc/bazel/3rdparty/update_cargo_deps.sh

@github-actions github-actions bot added Ruby Rust Pull requests that update Rust code labels Jan 8, 2025
@redsun82
Copy link
Contributor Author

redsun82 commented Jan 8, 2025

hmm, seems like the rust analyzer update breaks analysis on Windows. Let me maybe split out that update into separate work.

The rust-analyzer update will need more work as it seems to break rust
analysis on windows.

This was carried out using `cargo upgrade` from `cargo-edit`:
* getting exclusions options for rust-analyzer with
   ```bash
   cargo upgrade -i --dry-run | grep -o 'ra_ap_\S\+' | sort -u | sed 's/^/--exclude=/' > /tmp/exclude
   ```
* running
   ```bash
   cargo upgrade -i $(cat /tmp/exclude)
   misc/bazel/3rdparty/update_cargo_deps.sh
   ```
@redsun82 redsun82 force-pushed the redsun82/cargo-upgrade branch from 1a5a2a2 to d2c7dec Compare January 8, 2025 09:00
@redsun82 redsun82 changed the title Ruby, Rust: upgrade all cargo dependencies Ruby, Rust: upgrade all cargo dependencies (excluding rust-analyzer) Jan 8, 2025
@redsun82 redsun82 marked this pull request as ready for review January 8, 2025 09:34
@redsun82 redsun82 requested review from a team as code owners January 8, 2025 09:34
@redsun82 redsun82 merged commit bca5f4b into main Jan 8, 2025
53 checks passed
@redsun82 redsun82 deleted the redsun82/cargo-upgrade branch January 8, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants