Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu-profile interactive command #1358

Merged
merged 10 commits into from
Jan 31, 2024

Conversation

timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Dec 23, 2023

A Pull Request should be associated with an Issue.

Related issue: #1359

Description

This PR adds the cpu-profile interactive command which:

  1. Returns a runtime/pprof CPU profile as a base64-encoded string
    • Default 30s duration if no duration provided. Override-able eg: cpu-profile=10s
  2. Optional gzip compression eg: cpu-profile=15s,gzip
  3. Optional block profile, eg: cpu-profile=30s,block

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Dec 23, 2023
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt linked an issue Dec 24, 2023 that may be closed by this pull request
@timvaillancourt timvaillancourt marked this pull request as ready for review December 24, 2023 00:57
timvaillancourt and others added 6 commits December 24, 2023 04:31
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt merged commit b1aae87 into github:master Jan 31, 2024
7 checks passed
@timvaillancourt timvaillancourt deleted the server-cmd-cpu-profile branch January 31, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add ability to profile gh-ost
2 participants