Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buster tarball build #879

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Fix buster tarball build #879

merged 3 commits into from
Aug 20, 2020

Conversation

timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Aug 20, 2020 •
edited
Loading

Description

The gh-ost-build-deploy-tarball CI job is now running under Debian buster and is no longer creating stretch and jessie tarballs like before

This PR continues a hack that was previously added for jessie/stretch until a better solution emerges

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

eguevara
eguevara approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@eguevara eguevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left a comment on whether stretch is needed? I already see both in github-builds prior to aug 19.

script/build-deploy-tarball Show resolved Hide resolved
@timvaillancourt timvaillancourt merged commit ce03757 into master Aug 20, 2020
@timvaillancourt timvaillancourt deleted the fix-buster-tarball-build branch August 20, 2020 20:08
@shlomi-noach
Copy link
Contributor

LOL

Chawniseyler
Chawniseyler reviewed Aug 21, 2020
View reviewed changes
Copy link

@Chawniseyler Chawniseyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/github/gh-ost/pull/879#issuecomment-677891493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chawniseyler Chawniseyler Chawniseyler left review comments

@eguevara eguevara eguevara approved these changes

@tomkrouper tomkrouper tomkrouper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timvaillancourt @shlomi-noach @tomkrouper @eguevara @Chawniseyler