Set the ServerName for TLS configuration #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TLS hostname validation used for the MySQL connection, the ServerName property needs to be set so that it knows which name to validate on the certificate. Without this option and with InsecureSkipVerify set to false, validation will error here with a fatal error otherwise: ``` FATAL tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config ```
|
@shlomi-noach how can we get the |
timvaillancourt
approved these changes
Jun 17, 2021
Heh, probably
Dunno? Possibly only a PR submitted by an owner kicks that specific build? Could be some new configuration. |
|
Rather: |
timvaillancourt
temporarily deployed
to
production/mysql_role=ghost_testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TLS hostname validation used for the MySQL connection, the ServerName property needs to be set so that it knows which name to validate on the certificate.
Without this option and with InsecureSkipVerify set to false, validation will error here with a fatal error otherwise:
I'm not sure if there's a good way to additional test this specific change, as there's not a lot of extensive tests around the TLS handling and setup methods like
UseTLSfor example.I think this change is also necessary to be able to complete #521.