Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle empty deployment config yaml file #731

Open
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from
Open

fix: handle empty deployment config yaml file #731

wants to merge 1 commit into from

Conversation

PendaGTP
Copy link
Contributor

@PendaGTP PendaGTP commented Jan 6, 2025 •
edited
Loading

Fixes #730

Changes:

  • Add || {} fallback for yaml.load() results
  • Add || [] fallback for array properties (overridevalidators and configvalidators)
  • Add array validation before iteration

Testing:

  • Verified handling of empty config file
  • Verified handling of null array cases

@PendaGTP
Copy link
Contributor Author

PendaGTP commented Jan 6, 2025 •
edited
Loading

Current implementation: deployment-settings.yml uses defaults when missing but not when empty.

Consider either:

  • using defaults for both missing and empty files
  • documenting that empty files clear defaults

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty deployment-settings.yml cause error
1 participant
@PendaGTP