Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a .zip database kills the extension #621

Closed
agustingianni opened this issue Oct 17, 2020 · 8 comments · Fixed by #700
Closed

Importing a .zip database kills the extension #621

agustingianni opened this issue Oct 17, 2020 · 8 comments · Fixed by #700
Labels
bug Something isn't working VSCode

Comments

@agustingianni
Copy link

Describe the bug
Importing a .zip database kills the extension

To Reproduce

Expected behavior
The database is imported

@aeisenberg
Copy link
Contributor

Discovered a different, but related bug when looking into this.

Linux C++ is a very large database. The extension must be running into memory limits when trying to import.

@aeisenberg
Copy link
Contributor

I just tried downloading the db and importing it as a zip. It worked for me. So, my guess would be this is a systems resource issue on your end. Can you let me know what sort of machine this is? Memory, architecture, OS, CPU, etc.

@agustingianni
Copy link
Author

agustingianni commented Oct 17, 2020

Downloading it from LGTM does not work either :(

My machine is a macbook pro, 2,5 GHz Quad-Core Intel Core i7, 16 GB 1600 MHz DDR3.

@aeisenberg
Copy link
Contributor

I do wonder if 16 Gb is enough.

If you unzip the database yourself and import the database from the file system, does that work?

@agustingianni
Copy link
Author

Yes it does work if I unzip it first and then load it. Weird.

@aeisenberg
Copy link
Contributor

I think the difference is that importing as a zip through vscode, we are streaming the data through the extension and using more memory than unzipping directly from the OS.

I may need to re-work how we approach this and unzip out of process.

@agustingianni
Copy link
Author

Sweet, makes sense, let me know if I can help in any way.

@Manouchehri
Copy link

Hmm, I wonder if #699 is related? In my case, the extension doesn't die.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants