Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Download from LGTM for certain databases. #622

Closed
aeisenberg opened this issue Oct 17, 2020 · 1 comment · Fixed by #700
Closed

Unable to Download from LGTM for certain databases. #622

aeisenberg opened this issue Oct 17, 2020 · 1 comment · Fixed by #700
Labels
bug Something isn't working VSCode

Comments

@aeisenberg
Copy link
Contributor

Certain databases cannot be imported directly from LGTM. They must first be saved to disk and then imported. An example is https://lgtm.com/projects/g/torvalds/linux/ci/#ql (the python database).

I discovered this when looking into #621.

I think this is because of how the zip file is constructed. Our current approach is to unzip the http request as it streams in, but this is more error prone if the central directory is not completely correct. See ZJONSSON/node-unzipper#149

I may need to try another approach, where we first download the zip file to disk, and then unzip it into the extension.

@aeisenberg aeisenberg added the bug Something isn't working label Oct 17, 2020
@aeisenberg
Copy link
Contributor Author

Just got a message that the following small database is also failing. amphtml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant